Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various issues identified by code scanning #1508

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Nov 22, 2024

Platforms affected

iOS

Motivation and Context

Resolves some issues that were flagged by code scanning.

Description

  • Ensure temporary test projects are always cleaned up
  • Fix some bad regexes

Testing

Existing tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue added this to the 8.0.0 milestone Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (c995cd2) to head (6199d25).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1508       +/-   ##
===========================================
+ Coverage        0   80.95%   +80.95%     
===========================================
  Files           0       16       +16     
  Lines           0     1848     +1848     
===========================================
+ Hits            0     1496     +1496     
- Misses          0      352      +352     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dpogue dpogue merged commit 83981c9 into apache:master Nov 22, 2024
11 checks passed
@dpogue dpogue deleted the codeql-fixes branch November 22, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants