refactor(tests): Use XCTestPlans for unit testing #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to set up default behaviour of re-running tests up to 3 times if they fail, which should significantly cut down the number of failing builds in CI. I also opted to only keep the unit tests for the case where CordovaLib is consumed as a framework, since that's now the default behaviour for the template app (using Swift Packages) rather than a static library. Also cleaned up the test app project naming and moved some boilerplate stuff over to Swift.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1509 +/- ##
===========================================
+ Coverage 0 80.97% +80.97%
===========================================
Files 0 16 +16
Lines 0 1850 +1850
===========================================
+ Hits 0 1498 +1498
- Misses 0 352 +352 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
This allows us to set up default behaviour of re-running tests up to 3 times if they fail, which should significantly cut down the number of failing builds in CI.
Description
Move from Xcode schemes to XCTestPlans.
I also opted to only keep the unit tests for the case where CordovaLib is consumed as a framework, since that's now the default behaviour for the template app (using Swift Packages) rather than a static library.
Also cleaned up the test app project naming and moved some boilerplate stuff over to Swift.
Testing
Tests pass locally and in CI.
Checklist