feat(plugins): Better define plugin behaviour protocols #1514
+151
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 16 16
Lines 1855 1855
=======================================
Hits 1509 1509
Misses 346 346 ☔ View full report in Codecov by Sentry. |
dpogue
force-pushed
the
plugin-protocols
branch
2 times, most recently
from
81ea6a4 to
778b874
Compare
Closes apacheGH-1212. Co-Authored-By: Christopher J. Brody <chris.brody+brodybits@gmail.com>
This also adds a dictionary parameter containing the other navigation action details so that plugins can make choices based on frames. Closes apacheGH-1272. Closes apacheGH-1333. Co-Authored-By: Michael Tamburro <61243400+msmtamburro@users.noreply.github.com>
dpogue
force-pushed
the
plugin-protocols
branch
from
778b874 to
2da37a6
Compare
dpogue
commented
Dec 27, 2024
| without a credential. | ||
| - Returns: A Boolean value indicating if the plugin is handling the request. | ||
| */ | ||
| - (BOOL)willHandleAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge completionHandler:(void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential * _Nullable))completionHandler; |
There was a problem hiding this comment.
@erisu Updated this to be willHandleAuthenticationChallenge and return a BOOL so that multiple plugins can have a chance to respond
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Closes GH-1212.
Closes GH-1272.
Closes GH-1333.
Description
Adds protocols to formalize the methods that plugins should implement to interact with behaviour around authentication challenges and navigation decisions.
For navigation decisions, we now pass along the full navigation action details as a dictionary.
This also adds the ability for plugins to intercept and respond to server authentication challenges.
Testing
All existing tests pass.
Checklist