fix(build): Allow platform args with double dash #1516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
The Cordova docs say to provide platform-specific arguments after a
--
on the CLI. Currently this works on Android, but does not work for iOS.Closes GH-1488.
Description
Ensure that we parse any extra (platform-specific) arguments passed from cordova-cli in to the iOS build command through
options.argv
. These are arguments that are provided after a--
to the CLI command.There is no change for existing arguments passed without the double dash.
The priority of arguments is now:
Testing
Added unit tests to cover argument parsing and fallback behaviour.
Checklist