fix(catalyst): Fix content behind titlebar #1517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
macOS Catalyst
Motivation and Context
Closes GH-1491.
Description
When showing a webview on macOS Catalyst, always position it below the titlebar when a titlebar is displayed. This has the side effect of making all the
safe-area-inset
values 0, regardless of theviewport-fit
value.Also adds a
HideDesktopTitlebar
preference to make the titlebar invisible on macOS Catalyst with content extending behind it. I named this in a generic way because it sounds like this should also be feasible to apply to the cordova-electron platform.When using a preference to disable drawing the titlebar,
safe-area-inset
works as expected (but generally requiresviewport-fit=cover
to be specified).Testing
Tested with
viewport-fit=cover
andviewport-fit=contain
and measured the calculatedsafe-area-inset-top
value.Checklist