Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2055: Internal Server Error Encountered When Accessing Individual Collection Sheet Option #3750

Conversation

Mariappan-Sivakumar-ZS0528
Copy link
Contributor

@Mariappan-Sivakumar-ZS0528 Mariappan-Sivakumar-ZS0528 commented Feb 15, 2024

FINERACT-2055
Issue: Internal Server Error Encountered When Accessing Individual Collection Sheet Option

This issue is caused by the usage of the 'of' keyword as an alias for the 'm_office' table. When capturing rows from the 'm_office' table with the alias 'of', it triggers an error.

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

…idual Collection Sheet Option

This error is caused by the usage of the 'of' keyword as an alias for the 'm_office' table. When capturing rows from the 'm_office' table with the alias 'of', it triggers an error.
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Mar 17, 2024
@adamsaghy
Copy link
Contributor

@Mariappan-Sivakumar-ZS0528 Please help me understand why renaming the alias would sort this issue?

@github-actions github-actions bot removed the stale label Apr 4, 2024
@Mariappan-Sivakumar-ZS0528
Copy link
Contributor Author

Hi @adamsaghy
While using 'of' as an alias for the 'm_office' table in MySQL, it's not recognized as an alias but rather as a reserved keyword in SQL. Therefore, employing 'of' in that context triggers an error. By renaming the alias to 'off', we resolve this issue as 'off' is a valid alias and doesn't conflict with SQL keywords.

@adamsaghy adamsaghy closed this Apr 4, 2024
@adamsaghy adamsaghy reopened this Apr 4, 2024
Copy link

github-actions bot commented May 5, 2024

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label May 5, 2024
@github-actions github-actions bot closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants