FINERACT-1926: Fix No Such Element exception in Asset buyback #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Apr 11, 2024
| try { | ||
| handleBuyback(loan, settlementDate, transfer); | ||
| } catch (ExternalAssetOwnerTransferNotFoundException e) { | ||
| log.error(e.getMessage()); |
There was a problem hiding this comment.
I would not use try catch for this. Please consider removing the logging and move the entry creation back to the handleBuyback method and instead of throwing an error, just execute these.
Also please dont forget you need send business events from the CANCELLED status change too!
There was a problem hiding this comment.
Done! code updated based on our conversation
|
@alberto-art3ch I dont see any testing! |
adamsaghy
requested changes
Apr 11, 2024
alberto-art3ch
force-pushed
the
fix/nee_asset_buyback_cob
branch
from
2046184 to
ef8a8b4
Compare
alberto-art3ch
force-pushed
the
fix/nee_asset_buyback_cob
branch
from
c9f1e82 to
473dbd8
Compare
alberto-art3ch
force-pushed
the
fix/nee_asset_buyback_cob
branch
from
473dbd8 to
134f0c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a NoSuchElementException when the Loan COB is executed in some specific scenario.
FINERACT-1926
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.