-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Update version to 19.0 #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether the version is correct. it seems like we missed doing this update as part of the 17.0 release and you had to do it separately in the 18.0 branch. Can you confirm?
We might need to update the release documentation here. 🤔
flink-shaded-asm-9/pom.xml
Outdated
@@ -25,11 +25,11 @@ under the License. | |||
<parent> | |||
<groupId>org.apache.flink</groupId> | |||
<artifactId>flink-shaded</artifactId> | |||
<version>17.0</version> | |||
<version>18.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we do an update to 19.0 here (because it's on master)? Similar to how it was done in 725c0ca. I guess, we missed doing it when 17.0 was released. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, we missed doing it when 17.0 was released. 🤔
I believe we didn't update flink-shaded
for one of the Flink minor upgrades, because there was (at that moment) no reason to do the update. I don't think that we're following the strict versioning, more an indicator that there's no compatibility guarantees between flink-shaded
version upgrades.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that there is no need to update the version in master
if there's no change that's applied. But it would be still good to add this as part of the release documentation, wouldn't it? To ensure that we're not forgetting to update the version if a change is applied later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the response
updated to 19.0
also updated confluence [1] section Checklist to declare the process completed
[1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+flink-shaded+release
Actually this is a good point, thanks for raising it [1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+flink-shaded+release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @snuyanzin . LGTM. I added an example commit to the Confluence page as well.
Apply update to
18.019.0 to master branchcherry-pick of tagged commit 8ac82a3