GUACAMOLE-1844 : OIDC JWT claims as user token #943
Merged
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
requested changes
Jan 16, 2024
There was a problem hiding this comment.
@mildis This looks fine overall - I just have a couple of style requests.
...-sso-openid/src/main/java/org/apache/guacamole/auth/openid/token/TokenValidationService.java
Outdated
Show resolved
Hide resolved
...-sso-openid/src/main/java/org/apache/guacamole/auth/openid/token/TokenValidationService.java
Outdated
Show resolved
Hide resolved
mildis
force-pushed
the
oidc_custom_tokens
branch
from
a2dfa59 to
4668af7
Compare
mildis
force-pushed
the
oidc_custom_tokens
branch
from
4668af7 to
3262f45
Compare
necouchman
approved these changes
Jan 18, 2024
mildis
force-pushed
the
oidc_custom_tokens
branch
from
3262f45 to
4cb710e
Compare
mildis
force-pushed
the
oidc_custom_tokens
branch
from
4e24993 to
4cb710e
Compare
GUACAMOLE-1844 : OIDC JWT claims as user token This patch allows IDP to send JWT claims that can be mapped to user tokens, prefixed with OIDC_. Same case transormation apply than LDAP_ and CAS_. Define openid-attributes-claim-type with a comma-separated list of claims that should be mapped. Multivalued JWT claims are not unrolled.
mildis
force-pushed
the
oidc_custom_tokens
branch
from
4cb710e to
8c42553
Compare
|
Yeah sorry, bad handling of a rebase… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUACAMOLE-1844 : OIDC JWT claims as user token
This patch allows IDP to send JWT claims that can be mapped to user tokens, prefixed with OIDC_. Same case transormation apply than LDAP_ and CAS_.
Define openid-attributes-claim-type with a comma-separated list of claims that should be mapped.
Multivalued JWT claims are not unrolled.