-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move existing assignments usage calculation to pre-process stage #2888
Merged
junkaixue
merged 3 commits into
apache:helix-stickiness-rebalancer
from
frankmu:helix-stickiness-rebalancer
Aug 29, 2024
Merged
Move existing assignments usage calculation to pre-process stage #2888
junkaixue
merged 3 commits into
apache:helix-stickiness-rebalancer
from
frankmu:helix-stickiness-rebalancer
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkaixue
reviewed
Aug 23, 2024
.../src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Aug 29, 2024
.../src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
Show resolved
Hide resolved
.../src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
Outdated
Show resolved
Hide resolved
junkaixue
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
This PR is ready to be merged. Approved by @junkaixue |
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2024
Move existing assignments usage calculation to pre-process stage
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2024
Move existing assignments usage calculation to pre-process stage
xyuanlu
pushed a commit
that referenced
this pull request
Sep 11, 2024
Move existing assignments usage calculation to pre-process stage
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2024
Move existing assignments usage calculation to pre-process stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
resolves #2822
Description
One of the key steps of sticky rebalance strategy is to populate the previous node usage based on current mapping. Previous we do this in rebalance stage where we don't have the node usage info from global view. e.g. if the nodeA has resource1, then in rebalance stage of resource2, we don't have this info anymore. This PR moves the existing assignments usage calculation to pre-process stage where we will have the global view for all resources.
Will add one more test in following PR when #2889 is merged from master to this feature branch.
Tests
helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestStickyRebalanceStrategy.java
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)