-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BestPossibleExternalViewVerifier for WAGED resource #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpinto
reviewed
Oct 7, 2024
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Outdated
Show resolved
Hide resolved
zpinto
reviewed
Oct 7, 2024
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Oct 7, 2024
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Outdated
Show resolved
Hide resolved
xyuanlu
reviewed
Oct 8, 2024
.../src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
Outdated
Show resolved
Hide resolved
xyuanlu
approved these changes
Oct 8, 2024
PR approved by @xyuanlu. TFTR. Commit message: Fix BestPossibleExternalViewVerifier for WAGED resource |
zpinto
pushed a commit
to zpinto/helix
that referenced
this pull request
Oct 9, 2024
Fix the bug where BestPossibleExternalViewVerifier fails to accurately verify WAGED resources. If the user has requested the WAGED resources, the verifier should run against the resources of whole cluster.
Merged
1 task
zpinto
added a commit
to linkedin/helix
that referenced
this pull request
Oct 9, 2024
Cherry Pick: Fix BestPossibleExternalViewVerifier for WAGED resource (apache#2939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
BestPossibleExternalViewVerifier Fails to Accurately Verify WAGED Resources Due to Incomplete Cluster State Consideration #2938
Description
Fix the bug where BestPossibleExternalViewVerifier fails to accurately verify WAGED resources. If the user has requested the WAGED resources, the verifier should run against the resources of whole cluster. We can achieve it by
_resources.clear()
.Tests
The current test should be enough to capture this.
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)