Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BestPossibleExternalViewVerifier for WAGED resource #2939

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

MarkGaox
Copy link
Contributor

@MarkGaox MarkGaox commented Oct 7, 2024

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Fix the bug where BestPossibleExternalViewVerifier fails to accurately verify WAGED resources. If the user has requested the WAGED resources, the verifier should run against the resources of whole cluster. We can achieve it by _resources.clear().

Tests

  • The following tests are written for this issue:

The current test should be enough to capture this.

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@MarkGaox
Copy link
Contributor Author

MarkGaox commented Oct 9, 2024

PR approved by @xyuanlu. TFTR. Commit message: Fix BestPossibleExternalViewVerifier for WAGED resource

@xyuanlu xyuanlu merged commit 5b1a036 into apache:master Oct 9, 2024
2 checks passed
zpinto pushed a commit to zpinto/helix that referenced this pull request Oct 9, 2024
Fix the bug where BestPossibleExternalViewVerifier fails to accurately verify WAGED resources. If the user has requested the WAGED resources, the verifier should run against the resources of whole cluster.
zpinto added a commit to linkedin/helix that referenced this pull request Oct 9, 2024
Cherry Pick: Fix BestPossibleExternalViewVerifier for WAGED resource (apache#2939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants