Enabled replicaCount #269
Open
Enabled replicaCount #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhangNing10
requested changes
Apr 2, 2024
There was a problem hiding this comment.
hi @angelsanchezdck , thanks for creating the pr!
Different deployments/statefulset uses different values, for example .Values.lake.replicaCount. Then you can delete the values.replicaCount part in values.yaml
|
Hi @ZhangNing10 , Done! ui: No limit |
|
hi @angelsanchezdck , thanks a lot! could you kindly fix the conflict? |
|
Sorry for late. |
|
What is the next step? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the ability to set replicas of StatefulSet and deployments to 0, fully disabling the devlake-helm-chart. This ensures compliance with the requirement of having only one replica for deployments in dev-lake, providing finer control over the development environment.
Issue: #266