fix: pagerduty remote api not working (#7485)

apache · May 17, 2024 · 2bfc400 · 2bfc400
1 parent a42e3ee
commit 2bfc400
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/backend/plugins/pagerduty/api/remote_api.go b/backend/plugins/pagerduty/api/remote_api.go
@@ -46,21 +46,23 @@ type ServiceResponse struct {
 }
 
 func queryPagerdutyRemoteScopes(
-	connection *models.PagerDutyConnection,
 	apiClient plugin.ApiClient,
-	groupId string,
+	_ string,
 	page PagerdutyRemotePagination,
 	search string,
 ) (
 	children []dsmodels.DsRemoteApiScopeListEntry[models.Service],
 	nextPage *PagerdutyRemotePagination,
 	err errors.Error,
 ) {
+	if page.Limit == 0 {
+		page.Limit = 50
+	}
 	var res *http.Response
 	res, err = apiClient.Get("/services", url.Values{
 		"offset": {strconv.Itoa(page.Offset)},
 		"limit":  {strconv.Itoa(page.Limit)},
-		"search": {search},
+		"query":  {search},
 	}, nil)
 	if err != nil {
 		return
@@ -85,7 +87,6 @@ func queryPagerdutyRemoteScopes(
 					NoPKModel: common.NoPKModel{
 						CreatedAt: service.CreatedAt,
 					},
-					ConnectionId: connection.ID,
 				},
 			},
 		})
@@ -112,7 +113,7 @@ func listPagerdutyRemoteScopes(
 	*PagerdutyRemotePagination,
 	errors.Error,
 ) {
-	return queryPagerdutyRemoteScopes(connection, apiClient, groupId, page, "")
+	return queryPagerdutyRemoteScopes(apiClient, groupId, page, "")
 }
 
 func searchPagerdutyRemoteScopes(
@@ -122,7 +123,7 @@ func searchPagerdutyRemoteScopes(
 	children []dsmodels.DsRemoteApiScopeListEntry[models.Service],
 	err errors.Error,
 ) {
-	children, _, err = queryPagerdutyRemoteScopes(nil, apiClient, "", PagerdutyRemotePagination{
+	children, _, err = queryPagerdutyRemoteScopes(apiClient, "", PagerdutyRemotePagination{
 		Offset: (params.Page - 1) * params.PageSize,
 		Limit:  params.PageSize,
 	}, params.Search)