Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick Update error message #8086 to v1.0 #8087

Merged
merged 3 commits into from
Sep 20, 2024
+2 −2
Merged

cherry pick Update error message #8086 to v1.0 #8087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89eb66c
fix(project): project cannot be deleted when its pipelines are not fi…
d4x1 Sep 20, 2024
f549187
chore(framework): update error message
d4x1 Sep 20, 2024
d71c656
Merge branch 'release-v1.0' into cp10
d4x1 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/server/services/blueprint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func DeleteBlueprint(id uint64) errors.Error {
return err
}
if pipelinesAreUnfinished {
return errors.Default.New("There are unfinished pipelines under current blueprint. It can not be deleted now.")
return errors.Default.New("There are unfinished pipelines in the current project. It cannot be deleted at this time.")
}
err = bpManager.DeleteBlueprint(bp.ID)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion backend/server/services/project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ func DeleteProject(name string) errors.Error {
return err
}
if pipelinesAreUnfinished {
return errors.Default.New("There are unfinished pipelines under current project. It can not be deleted now.")
return errors.Default.New("There are unfinished pipelines in the current project. It cannot be deleted at this time.")
}
err = deleteProjectBlueprint(name)
if err != nil {
Expand Down
Loading