Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Upgrade WORKSPACE python packages for python3.8 support #3646

Merged
merged 44 commits into from
Jan 25, 2022

Conversation

Code0x58
Copy link
Contributor

@Code0x58 Code0x58 commented Dec 8, 2020

This upgrades a few python packages. One benefit is that infrastructure/tests work on python3.9 (due to upgrading pex to a version that says it can be installed in python <=3.9) so will fix the issue seen in #3638

@Code0x58 Code0x58 marked this pull request as draft December 8, 2020 20:11
@nicknezis
Copy link
Contributor

Looks good. What else is needed to remove from draft status?

@joshfischer1108
Copy link
Member

@Code0x58 What do we need to do to pick up work on this branch? Anything I can help with?

@Code0x58
Copy link
Contributor Author

Code0x58 commented Feb 4, 2021

I think with these changes the python version in Travis blows up, or image (tested via ./scripts/release/build-images --all) having versions that blow up during the build.

I can't recall what specifically required a change from 3.6 to something higher - probably just the newer libraries that work with 3.9.

One path forward is to upgrade all the python versions installed in the container images+CI (Travis + Ubuntu vagrant manifests) to some minimum version - you could use pyenv in the Vagrant machine to find what the lowest working version is. This would be a bit of a pain due to the multiple runtimes required to use Heron, so can't just use pre-existing base images (I think the JRE may be the first class citizen for that in the images). It's not a particularly appealing change, especially considering it may force python tennants to try upgrading their code+dependencies, but it's probably a reasonable thing to do without reconsidering the whole architecture or trying stick with Python 3.6-3.8 only.

@nwangtw
Copy link
Contributor

nwangtw commented Feb 4, 2021 via email

@nicknezis nicknezis mentioned this pull request Mar 4, 2021
@nicknezis nicknezis marked this pull request as ready for review January 18, 2022 04:45
.travis.yml Outdated Show resolved Hide resolved
@surahman surahman force-pushed the upgrade-py-dependencies branch 2 times, most recently from c9dd9c9 to 9f1a612 Compare January 18, 2022 21:47
@nicknezis nicknezis self-assigned this Jan 21, 2022
@nicknezis
Copy link
Contributor

#3642 Code was integrated into this PR.

Tracker Behavior changes:

  • replace //topologies redirect with (OpenAPI on ReDoc) documentation
  • deprecate executiontime and always return 0.0 for it in the response envelope - this could probably be put back in, but I don't think it's worth it
  • inbound requests aren't terminated if they take over 120s. At the moment, every outbound request has a 5s limit (due to httpx default) so I wouldn't expect the timeout to be needed (even in metrics queries which may transform data). A replacement timeout could be added in if necessary.

@nicknezis nicknezis mentioned this pull request Jan 24, 2022
4 tasks
@nicknezis nicknezis merged commit abb2767 into apache:master Jan 25, 2022
@surahman surahman changed the title Upgrade WORKSPACE python packages for python3.9 support Upgrade WORKSPACE python packages for python3.8 support Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants