apache · nicknezis · Mar 25, 2022 · Feb 27, 2022 · Feb 27, 2022 · Feb 27, 2022
diff --git a/WORKSPACE b/WORKSPACE
@@ -173,6 +173,16 @@ load(
 )
 jar_jar_repositories()
 
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+http_archive(
+    name = "platforms",
+    urls = [
+        "https://mirror.bazel.build/github.com/bazelbuild/platforms/releases/download/0.0.5/platforms-0.0.5.tar.gz",
+        "https://github.com/bazelbuild/platforms/releases/download/0.0.5/platforms-0.0.5.tar.gz",
+    ],
+    sha256 = "379113459b0feaf6bfbb584a91874c065078aa673222846ac765f86661c27407",
+)
+
 http_archive(
     name = "rules_python",
     sha256 = "b6d46438523a3ec0f3cead544190ee13223a52f6a6765a29eae7b7cc24cc83a0",

diff --git a/docker/compile/Dockerfile.debian10 b/docker/compile/Dockerfile.debian10
@@ -17,9 +17,6 @@
 
 FROM openjdk:11.0.6-jdk-buster
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM linux
-
 ENV LC_ALL C.UTF-8
 ENV LANG C.UTF-8
 

diff --git a/docker/compile/Dockerfile.rocky8 b/docker/compile/Dockerfile.rocky8
@@ -17,11 +17,8 @@
 
 FROM rockylinux:8.5
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM linux
-
-RUN yum -y upgrade
-RUN yum -y install \
+RUN yum -y upgrade \
+   && yum -y install \
       ant \
       automake \
       curl \

diff --git a/docker/compile/Dockerfile.ubuntu18.04 b/docker/compile/Dockerfile.ubuntu18.04
@@ -17,9 +17,6 @@
 
 FROM ubuntu:18.04
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM linux
-
 ARG DEBIAN_FRONTEND=noninteractive
 
 ENV LC_ALL C.UTF-8

diff --git a/docker/compile/Dockerfile.ubuntu20.04 b/docker/compile/Dockerfile.ubuntu20.04
@@ -17,9 +17,6 @@
 
 FROM ubuntu:20.04
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM linux
-
 ARG DEBIAN_FRONTEND=noninteractive
 
 ENV LC_ALL C.UTF-8

diff --git a/docker/compile/Dockerfile.ubuntu22.04 b/docker/compile/Dockerfile.ubuntu22.04
@@ -17,9 +17,6 @@
 
 FROM ubuntu:22.04
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM ubuntu
-
 ARG DEBIAN_FRONTEND=noninteractive
 
 ENV LC_ALL C.UTF-8

diff --git a/docker/dist/Dockerfile.dist.rocky8 b/docker/dist/Dockerfile.dist.rocky8
@@ -18,7 +18,7 @@
 #syntax=docker/dockerfile:1.2
 FROM rockylinux:8.5
 
-RUN yum -y install epel-release \
+RUN yum -y upgrade \
     && yum -y install \
     curl \
     java-11-openjdk-headless \

diff --git a/docker/scripts/compile-docker.sh b/docker/scripts/compile-docker.sh
@@ -36,13 +36,8 @@ dockerfile_path_for_platform() {
   echo "$SCRATCH_DIR/compile/Dockerfile.$1"
 }
 
-copy_bazel_rc_to() {
-  cp $PROJECT_DIR/tools/docker/bazel.rc $1
-}
-
 DOCKER_FILE=$(dockerfile_path_for_platform $TARGET_PLATFORM)
 verify_dockerfile_exists $DOCKER_FILE
-copy_bazel_rc_to $SCRATCH_DIR/bazelrc
 
 echo "Building heron-compiler container"
 docker buildx build -t heron-compiler:$TARGET_PLATFORM -f $DOCKER_FILE $SCRATCH_DIR

diff --git a/docker/scripts/compile-platform.sh b/docker/scripts/compile-platform.sh
@@ -36,29 +36,14 @@ cd $SCRATCH_DIR
 echo "Extracting source"
 tar -C . -xzf $SOURCE_TARBALL
 
-if [[ "$TARGET_PLATFORM" =~ "ubuntu" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "centos" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "rocky" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "debian" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "darwin" ]]; then
-  CONFIG_PLATFORM=darwin_nostyle
-else
-  echo "Unknown platform: $TARGET_PLATFORM"
-  exit 1
-fi
-
 bazel version
 ./bazel_configure.py
 bazel clean
 
 echo "Creating packages"
-bazel build -c opt --jobs 25 --config=$CONFIG_PLATFORM scripts/packages:tarpkgs
-bazel build -c opt --jobs 25 --config=$CONFIG_PLATFORM scripts/packages:binpkgs
-bazel build -c opt --jobs 25 --config=$CONFIG_PLATFORM scripts/images:heron.tar
+bazel build -c opt --copt=-O3 scripts/packages:tarpkgs
+bazel build -c opt --copt=-O3 scripts/packages:binpkgs
+bazel build -c opt --copt=-O3 scripts/images:heron.tar
 
 echo "Moving packages to /$OUTPUT_DIRECTORY"
 for file in ./bazel-bin/scripts/packages/*.tar.gz; do

diff --git a/docker/scripts/dev-env-create.sh b/docker/scripts/dev-env-create.sh
@@ -28,8 +28,8 @@
 # After the container is started, you can build Heron with bazel
 # (ubuntu config is used in the example):
 #   ./bazel_configure.py
-#   bazel build --config=linux heron/...
-#   bazel build --config=linux scripts/packages:binpkgs
+#   bazel build heron/...
+#   bazel build scripts/packages:binpkgs
 
 set -o nounset
 set -o errexit
@@ -69,7 +69,6 @@ dockerfile_path_for_platform() {
 
 copy_extra_files() {
   mkdir -p $SCRATCH_DIR/scripts
-  cp $PROJECT_DIR/tools/docker/bazel.rc $SCRATCH_DIR/bazelrc
   cp $DOCKER_DIR/scripts/compile-docker.sh $SCRATCH_DIR/scripts/compile-platform.sh
 }
 

diff --git a/docker/scripts/test-docker.sh b/docker/scripts/test-docker.sh
@@ -36,13 +36,8 @@ dockerfile_path_for_platform() {
   echo "$SCRATCH_DIR/test/Dockerfile.$1"
 }
 
-copy_bazel_rc_to() {
-  cp $PROJECT_DIR/tools/docker/bazel.rc $1
-}
-
 DOCKER_FILE=$(dockerfile_path_for_platform $TARGET_PLATFORM)
 verify_dockerfile_exists $DOCKER_FILE
-copy_bazel_rc_to  $SCRATCH_DIR/bazelrc
 
 echo "Building heron-compiler container"
 docker buildx build -t heron-compiler:$TARGET_PLATFORM -f $DOCKER_FILE $SCRATCH_DIR

diff --git a/docker/scripts/test-platform.sh b/docker/scripts/test-platform.sh
@@ -36,28 +36,12 @@ cd $SCRATCH_DIR
 echo "Extracting source"
 tar -C . -xzf $SOURCE_TARBALL
 
-if [[ "$TARGET_PLATFORM" =~ "ubuntu" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "centos" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "rocky" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-elif [[ "$TARGET_PLATFORM" =~ "darwin" ]]; then
-  CONFIG_PLATFORM=darwin
-elif [[ "$TARGET_PLATFORM" =~ "debian" ]]; then
-  CONFIG_PLATFORM=linux_nostyle
-else
-  echo "Unknown platform: $TARGET_PLATFORM"
-  exit 1
-fi
-
 bazel version
 ./bazel_configure.py
 bazel clean
 
 echo "UnitTest"
-bazel test -c opt --jobs 25 \
-    --config=$CONFIG_PLATFORM \
+bazel test -c opt \
     --test_output=all \
     --test_summary=detailed \
     heron/... \

diff --git a/docker/test/Dockerfile.centos7 b/docker/test/Dockerfile.centos7
@@ -17,10 +17,6 @@
 
 FROM centos:centos7
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM linux
-ENV LC_ALL en_US.utf8
-
 RUN yum -y upgrade && yum -y install centos-release-scl-rh
 RUN yum -y install \
       automake \
@@ -31,6 +27,7 @@ RUN yum -y install \
       devtoolset-8-gcc \
       devtoolset-8-gcc-c++ \
       git \
+      glibc-langpack-en \
       kernel-devel \
       libtool \
       make \
@@ -51,6 +48,7 @@ RUN /usr/bin/ln -sfT /opt/rh/rh-python38/root/usr/bin/python3 /usr/bin/python3 \
       && /usr/bin/ln -sfT /opt/rh/devtoolset-8/root/bin/g++ /usr/bin/g++ \
       && /usr/bin/ln -sfT /opt/rh/devtoolset-8/root/bin/cpp /usr/bin/cpp
 
+ENV LC_ALL en_US.utf8
 ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk
 
 ENV bazelVersion 4.2.2

diff --git a/docker/test/Dockerfile.rocky8 b/docker/test/Dockerfile.rocky8
@@ -20,8 +20,8 @@ FROM rockylinux:8.5
 # This is passed to the heron build command via the --config flag
 ENV TARGET_PLATFORM linux
 
-RUN yum -y upgrade
-RUN yum -y install \
+RUN yum -y upgrade \
+   && yum -y install \
       automake \
       curl \
       cmake \

diff --git a/docker/test/Dockerfile.ubuntu18.04 b/docker/test/Dockerfile.ubuntu18.04
@@ -17,8 +17,8 @@
 
 FROM ubuntu:18.04
 
-# This is passed to the heron build command via the --config flag
-ENV TARGET_PLATFORM linux
+ENV LC_ALL C.UTF-8
+ENV LANG C.UTF-8
 
 RUN apt-get update && apt-get -y install \
       g++ \

diff --git a/examples/src/scala/compile.sh b/examples/src/scala/compile.sh
@@ -32,7 +32,7 @@ function die {
 which scalac || die "scalac must be installed to run this script. Exiting."
 
 rm -f heron-storm.jar
-(cd $root && bazel build --config=darwin scripts/packages:tarpkgs)
+(cd $root && bazel build scripts/packages:tarpkgs)
 
 # Verify storm and heron bolts compile with heron-storm.jar
 scalac -cp bazel-bin/./storm-compatibility/v0.10.2/src/java/heron-storm.jar \

diff --git a/heron/common/src/cpp/basics/BUILD b/heron/common/src/cpp/basics/BUILD
@@ -54,7 +54,7 @@ cc_library(
         "@com_github_corvusoft_kashmir_cpp//:kashmir-cxx",
         "@com_google_protobuf//:protobuf",
     ] + select({
-        "//tools/platform:darwin": [],
+        "@platforms//os:osx": [],
         "//conditions:default": ["@org_nongnu_libunwind//:libunwind"],
     }),
 )
diff --git a/heron/common/src/cpp/metrics/BUILD b/heron/common/src/cpp/metrics/BUILD
@@ -43,7 +43,7 @@ cc_library(
         "@com_github_google_glog//:glog",
         "@com_google_protobuf//:protobuf",
     ] + select({
-        "//tools/platform:darwin": [],
+        "@platforms//os:osx": [],
         "//conditions:default": ["@org_nongnu_libunwind//:libunwind"],
     }),
 )
diff --git a/integration_test/README.md b/integration_test/README.md
@@ -46,9 +46,9 @@ To run integration tests on your mac first run the following to build the test p
 the heron client:
 
 ```Bash
-  bazel build --config=darwin integration_test/src/...
-  bazel run --config=darwin -- scripts/packages:heron-client-install.sh --user
-  bazel run --config=darwin -- scripts/packages:heron-tools-install.sh --user
+  bazel build integration_test/src/...
+  bazel run -- scripts/packages:heron-client-install.sh --user
+  bazel run -- scripts/packages:heron-tools-install.sh --user
 ```
 
 To run the local integration tests on your mac run the following from the heron repo's top dir:

diff --git a/integration_test/src/python/local_test_runner/README b/integration_test/src/python/local_test_runner/README
@@ -4,6 +4,6 @@ tuple to an output file and the two files are compared.
 
 To run the tests:
 
-  bazel run --config=darwin -- scripts/packages:heron-install.sh --user
-  bazel build --config=darwin integration_test/src/...
+  bazel run -- scripts/packages:heron-install.sh --user
+  bazel build integration_test/src/...
   ./bazel-bin/integration_test/src/python/local_test_runner/local-test-runner