Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two tests for SiteMapParserBolt #1138

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add two tests for SiteMapParserBolt #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 47 additions & 11 deletions core/src/test/java/com/digitalpebble/stormcrawler/bolt/SiteMapParserBoltTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ public void setupParserBolt() {
setupParserBolt(bolt);
}

// TODO add a test for a sitemap containing links
// to other sitemap files

@Test
public void testSitemapParsing() throws IOException {

Expand All @@ -62,9 +59,48 @@ public void testSitemapParsing() throws IOException {
Assert.assertEquals(3, fields.size());
}

@Test
public void testSitemapIndexParsing() throws IOException {

prepareParserBolt("test.parsefilters.json");

Metadata metadata = new Metadata();
// specify that it is a sitemap file
metadata.setValue(SiteMapParserBolt.isSitemapKey, "true");
// and its mime-type
metadata.setValue(HttpHeaders.CONTENT_TYPE, "application/xml");

parse(
"http://www.tripadvisor.com/sitemap-index.xml",
"tripadvisor.sitemap.index.xml",
metadata);

for (List<Object> fields : output.getEmitted(Constants.StatusStreamName)) {
Metadata parsedMetadata = (Metadata) fields.get(1);
Assert.assertEquals(
"true", parsedMetadata.getFirstValue(SiteMapParserBolt.isSitemapKey));
}

Assert.assertEquals(5, output.getEmitted(Constants.StatusStreamName).size());
}

@Test
public void testGzipSitemapParsing() throws IOException {

prepareParserBolt("test.parsefilters.json");

Metadata metadata = new Metadata();
// specify that it is a sitemap file
metadata.setValue(SiteMapParserBolt.isSitemapKey, "true");

parse("https://www.tripadvisor.com/sitemap.xml.gz", "tripadvisor.sitemap.xml.gz", metadata);

Assert.assertEquals(50001, output.getEmitted(Constants.StatusStreamName).size());
}

@Test
public void testSitemapParsingWithImageExtensions() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.extensions", Collections.singletonList(Extension.IMAGE.name()));
prepareParserBolt("test.parsefilters.json", parserConfig);

Expand All @@ -85,7 +121,7 @@ public void testSitemapParsingWithImageExtensions() throws IOException {

@Test
public void testSitemapParsingWithMobileExtensions() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.extensions", Collections.singletonList(Extension.MOBILE.name()));
prepareParserBolt("test.parsefilters.json", parserConfig);

Expand All @@ -106,7 +142,7 @@ public void testSitemapParsingWithMobileExtensions() throws IOException {

@Test
public void testSitemapParsingWithLinkExtensions() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.extensions", Collections.singletonList(Extension.LINKS.name()));
prepareParserBolt("test.parsefilters.json", parserConfig);

Expand All @@ -127,7 +163,7 @@ public void testSitemapParsingWithLinkExtensions() throws IOException {

@Test
public void testSitemapParsingWithNewsExtensions() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.extensions", Collections.singletonList(Extension.NEWS.name()));
prepareParserBolt("test.parsefilters.json", parserConfig);

Expand All @@ -148,7 +184,7 @@ public void testSitemapParsingWithNewsExtensions() throws IOException {

@Test
public void testSitemapParsingWithVideoExtensions() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.extensions", Collections.singletonList(Extension.VIDEO.name()));
prepareParserBolt("test.parsefilters.json", parserConfig);

Expand All @@ -169,7 +205,7 @@ public void testSitemapParsingWithVideoExtensions() throws IOException {

@Test
public void testSitemapParsingWithAllExtensions() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();

parserConfig.put(
"sitemap.extensions",
Expand Down Expand Up @@ -202,15 +238,15 @@ public void testSitemapParsingWithAllExtensions() throws IOException {

@Test(expected = IllegalArgumentException.class)
public void testSitemapParsingWithIllegalExtensionConfigured() throws IOException {
Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.extensions", Arrays.asList("AUDIONEWSLINKS"));
prepareParserBolt("test.parsefilters.json", parserConfig);
}

@Test
public void testSitemapParsingNoMT() throws IOException {

Map parserConfig = new HashMap();
Map<String, Object> parserConfig = new HashMap<>();
parserConfig.put("sitemap.sniffContent", true);
parserConfig.put("parsefilters.config.file", "test.parsefilters.json");
bolt.prepare(
Expand Down
22 changes: 22 additions & 0 deletions core/src/test/resources/tripadvisor.sitemap.index.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?><sitemapindex
xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9
http://www.sitemaps.org/schemas/sitemap/0.9/siteindex.xsd">
<sitemap>
<loc>https://www.tripadvisor.com/sitemap/2/en_US/sitemap-1806509-en_US-hotel_review-1686849999.xml.gz</loc>
<lastmod>2023-06-15T17:26:39Z</lastmod>
</sitemap>
<sitemap>
<loc>https://www.tripadvisor.com/sitemap/2/en_US/sitemap-1806530-en_US-hotel_review-1686850054.xml.gz</loc>
<lastmod>2023-06-15T17:27:34Z</lastmod>
</sitemap>
<sitemap>
<loc>https://www.tripadvisor.com/sitemap/2/en_US/sitemap-1806537-en_US-hotel_review-1686850072.xml.gz</loc>
<lastmod>2023-06-15T17:27:52Z</lastmod>
</sitemap>
<sitemap>
<loc>https://www.tripadvisor.com/sitemap/2/en_US/sitemap-1841024-en_US-hotel_review-1694976638.xml.gz</loc>
<lastmod>2023-09-17T18:50:38Z</lastmod>
</sitemap>
</sitemapindex>
Binary file added core/src/test/resources/tripadvisor.sitemap.xml.gz
View file
Open in desktop
Binary file not shown.