[Improve] [Flink-Kubernetes-V2] add observer untrack on Flink-Kubernetes-V2-Session #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into dev � Conflicts: � README.md
caicancai
changed the title
Al-assad
approved these changes
Oct 8, 2023
| @@ -125,6 +128,9 @@ object KubernetesSessionClientV2 extends KubernetesClientV2Trait with Logger { | |||
|
|
|||
| FlinkK8sOperator.k8sCrOpr.deleteSessionJob(namespace, name).runIOAsTry match { | |||
| case Success(_) => | |||
| observer.trackedKeys | |||
| .find(_.id == shutDownRequest.id) | |||
| .someOrUnitZIO(key => observer.untrack(key)) | |||
There was a problem hiding this comment.
This section is a ZIO value, so in fact it will not be executed.
| @@ -125,6 +128,9 @@ object KubernetesSessionClientV2 extends KubernetesClientV2Trait with Logger { | |||
|
|
|||
| FlinkK8sOperator.k8sCrOpr.deleteSessionJob(namespace, name).runIOAsTry match { | |||
There was a problem hiding this comment.
When the shutdown here is shutting down a flink cluster, the FlinkK8sOperator.delete() function should be called, which automatically untracks the flink cluster resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
[Improve] [FLink-Kubernetes-V2] add observer untrack on Flink-Kubernetes-V2-Session
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts