Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] [Flink-Kubernetes-V2] add observer untrack on Flink-Kubernetes-V2-Session #3216

Merged
merged 8 commits into from
Oct 8, 2023
Merged

[Improve] [Flink-Kubernetes-V2] add observer untrack on Flink-Kubernetes-V2-Session #3216

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff9ae3b
improve README.md
caicancai Sep 20, 2023
77bfdd0
Merge branch 'dev' of https://github.com/caicancai/incubator-streampa…
caicancai Sep 21, 2023
abbdeaf
Merge branch 'dev' of https://github.com/caicancai/incubator-streampa…
caicancai Sep 23, 2023
5169f6d
Merge branch 'dev' of https://github.com/caicancai/incubator-streampa…
caicancai Sep 26, 2023
65b7d70
[Improve]improve README.md
caicancai Sep 26, 2023
58c516a
Merge branch 'dev' of https://github.com/caicancai/incubator-streampa…
caicancai Oct 7, 2023
6a1d40f
[Bug][Flink-Kubernetes-V2] observer.untrack on FLink-Kubernetes-V2-se…
caicancai Oct 7, 2023
9833eb0
Improve KubernetesSessionClientV2.scala at PR#3216.
Al-assad Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...re/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesSessionClientV2.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
package org.apache.streampark.flink.client.impl

import org.apache.streampark.common.util.Logger
import org.apache.streampark.common.zio.ZIOExt.IOOps
import org.apache.streampark.common.zio.ZIOExt.{IOOps, OptionZIOOps}
import org.apache.streampark.flink.client.`trait`.KubernetesClientV2Trait
import org.apache.streampark.flink.client.bean._
import org.apache.streampark.flink.kubernetes.v2.model.FlinkSessionJobDef
import org.apache.streampark.flink.kubernetes.v2.observer.FlinkK8sObserver
import org.apache.streampark.flink.kubernetes.v2.operator.FlinkK8sOperator
import org.apache.streampark.flink.packer.pipeline.ShadedBuildResponse

Expand All @@ -34,6 +35,8 @@ import scala.util.{Failure, Success}

/** Flink K8s session mode app operation client via Flink K8s Operator */
object KubernetesSessionClientV2 extends KubernetesClientV2Trait with Logger {
private val observer = FlinkK8sObserver

@throws[Throwable]
override def doSubmit(
submitRequest: SubmitRequest,
Expand Down Expand Up @@ -125,6 +128,9 @@ object KubernetesSessionClientV2 extends KubernetesClientV2Trait with Logger {

FlinkK8sOperator.k8sCrOpr.deleteSessionJob(namespace, name).runIOAsTry match {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the shutdown here is shutting down a flink cluster, the FlinkK8sOperator.delete() function should be called, which automatically untracks the flink cluster resources

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

case Success(_) =>
observer.trackedKeys
.find(_.id == shutDownRequest.id)
.someOrUnitZIO(key => observer.untrack(key))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is a ZIO value, so in fact it will not be executed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

logInfo(richMsg("Shutdown Flink cluster successfully."))
ShutDownResponse()
case Failure(err) =>
Expand Down