-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-4077 JMAP - SearchSnippet/get method #2442
base: master
Are you sure you want to change the base?
Conversation
52b41f5
to
9f6bef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
...ox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/LuceneMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
...sts/src/test/java/org/apache/james/jmap/rfc8621/memory/MemorySearchSnippetGetMethodTest.java
Outdated
Show resolved
Hide resolved
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/highlight/SearchSnippetGetRequest.scala
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Outdated
Show resolved
Hide resolved
9f6bef8
to
14c3aed
Compare
...e/lucene/src/main/java/org/apache/james/modules/mailbox/LuceneMemorySearchMailboxModule.java
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Show resolved
Hide resolved
b6ada1b
to
ca36e1a
Compare
...ox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/LuceneMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read it nothing to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we have here three tickets at once:
-
- Back memory-app with Lucene
-
- Add Lucene support for attachment search (prerequisite of 1. unless we temporarily abandon attachment search in 1. ?
-
- And implement SearchSnippet/get (we can do this first onto distributed james)
Please split that in 3 PR...
pr: #2464
I will force push code to this pr.
Ticket: linagora#5306 |
3cb8bab
to
9724d38
Compare
The commit JAMES-4077 Back memory-app with Lucene need to spend time to update LuceneSearch (ref #2464) If we want to make this PR independent of it. I suggest two options:
|
+1 |
9724d38
to
8326bc4
Compare
jira https://issues.apache.org/jira/browse/JAMES-4077
resolve linagora#5254