JAMES-4077 JMAP - SearchSnippet/get method #2442
Open
+1,453
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vttranlina
force-pushed
the
SearchSnippetGetMethod
branch
from
52b41f5
to
9f6bef8
Compare
chibenwa
reviewed
Oct 9, 2024
...ox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/LuceneMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
...sts/src/test/java/org/apache/james/jmap/rfc8621/memory/MemorySearchSnippetGetMethodTest.java
Outdated
Show resolved
Hide resolved
...s/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/highlight/SearchSnippetGetRequest.scala
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Outdated
Show resolved
Hide resolved
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Outdated
Show resolved
Hide resolved
vttranlina
force-pushed
the
SearchSnippetGetMethod
branch
from
9f6bef8
to
14c3aed
Compare
chibenwa
reviewed
Oct 15, 2024
...e/lucene/src/main/java/org/apache/james/modules/mailbox/LuceneMemorySearchMailboxModule.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 15, 2024
...ocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/SearchSnippetGetMethod.scala
Show resolved
Hide resolved
vttranlina
force-pushed
the
SearchSnippetGetMethod
branch
from
b6ada1b
to
ca36e1a
Compare
vttranlina
changed the title
vttranlina
commented
Oct 21, 2024
...ox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/LuceneMessageSearchIndex.java
Outdated
Show resolved
Hide resolved
chibenwa
requested changes
Oct 21, 2024
There was a problem hiding this comment.
IMO we have here three tickets at once:
-
- Back memory-app with Lucene
-
- Add Lucene support for attachment search (prerequisite of 1. unless we temporarily abandon attachment search in 1. ?
-
- And implement SearchSnippet/get (we can do this first onto distributed james)
Please split that in 3 PR...
This was referenced Oct 22, 2024
pr: #2464
I will force push code to this pr.
Ticket: linagora#5306 |
vttranlina
force-pushed
the
SearchSnippetGetMethod
branch
from
3cb8bab
to
9724d38
Compare
|
The commit JAMES-4077 Back memory-app with Lucene need to spend time to update LuceneSearch (ref #2464) If we want to make this PR independent of it. I suggest two options:
|
+1 |
vttranlina
force-pushed
the
SearchSnippetGetMethod
branch
from
9724d38
to
8326bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira https://issues.apache.org/jira/browse/JAMES-4077
resolve linagora#5254