JAMES-2182 Sharing for IMAP #2445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: evening coding session, most spotted bugs and a few others are out of the way but extensive testing will be required. |
|
|
chibenwa
force-pushed
the
imap-sharing
branch
3 times, most recently
from
b21f6de
to
a3fcbd9
Compare
chibenwa
force-pushed
the
imap-sharing
branch
2 times, most recently
from
1baac9e
to
ba95f71
Compare
We do not need those IMAP concerns onto the storage layer. We will later come up with alternative implementation for namespace customization.
Guice implementors can then very easily overwrite the namespace definition
This will allow customization of the IMAP folder naming strategy.
…-> mailboxname - Centralize in one place the knowledge of encoding MailboxPath into IMAP
As we can only access resources within a single domain the domain is implicit and thus do not need to be repeated in the IMAP wording.
This common character conflicts with the path delimiter of the mailbox name and thus needs to be escaped.
Several issues remains to address:
- [ ] List + myrights needs to keep FQDN in the response
- [ ] #user shall not include personal mailboxes
filter them out?
(post filtering?)
- [ ] Using #user in mailbox name pattern shall be permitted
- [ ] Remove duplicate results...
chibenwa
force-pushed
the
imap-sharing
branch
from
ba95f71
to
babafcd
Compare
Arsnael
reviewed
Oct 22, 2024
mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Show resolved
Hide resolved
| if (!isWriteable(mailboxSession)) { | ||
| throw new ReadOnlyException(getMailboxPath()); | ||
| if (flagsUpdateMode.equals(FlagsUpdateMode.REPLACE)) { | ||
| if (!myRights.contains(MailboxACL.Right.Write, MailboxACL.Right.WriteSeenFlag, MailboxACL.Right.DeleteMessages)) { |
There was a problem hiding this comment.
Maybe containsAll? I had to go into the contain method to verify that all input rights have to be contained.
There was a problem hiding this comment.
I think it's rather explicit, and it is unrelated with this change set.
Maybe others have opinions?
protocols/imap/src/main/java/org/apache/james/imap/main/PathConverter.java
Show resolved
Hide resolved
protocols/imap/src/main/java/org/apache/james/imap/processor/NamespaceSupplier.java
Show resolved
Hide resolved
…ion to PathConverter This allows customization...
chibenwa
force-pushed
the
imap-sharing
branch
from
0455d60
to
ff04821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My second shot ever at this.
First a BIG refactoring centralizes the definition of path <-> name convertion into the IMAP layer (pre-requisite) and
provide a generic strategy that could be allowed to be overloaded (PathConverter + Namespace supplier).
A second part of this work is about exposing other users folder shared with the user into a
#userfolder.Remaining work:
I am happy, in 1 day coding it got quite far, though details needs to be addressed and more tests needs to be produced.