Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding access key auth support for openstack V3 #183

Merged

Conversation

edipdemirbilek
Copy link
Contributor

There was already a PR for adding access key auth support for openstack V3. But it was declined due to lack of tests.

We run into the same problem. I have tried that earlier PR and it really fixes the problem. So I have added test cases to the initial PR as is and submitting them all together in this PR.

@edipdemirbilek
Copy link
Contributor Author

Needs reviewer: @nacx @gaul

@nacx
Copy link
Member

nacx commented Sep 2, 2023

Thanks @edipdemirbilek! Could you fix the checkstyle violation to have the build green? The PR LGTM. I'll merge it once the build passes.
Thank you!

@edipdemirbilek
Copy link
Contributor Author

Thanks @edipdemirbilek! Could you fix the checkstyle violation to have the build green? The PR LGTM. I'll merge it once the build passes. Thank you!

done.

@edipdemirbilek
Copy link
Contributor Author

@nacx build is still failing but not due to keystone project anymore as far as I see. Another sub-project (google-cloud-storage) is failing and this seems to have been the case for 2 months.

@nacx nacx merged commit 611b4c4 into apache:master Sep 4, 2023
1 check failed
@nacx
Copy link
Member

nacx commented Sep 4, 2023

I fixed that in another PR.
Thank you!

@edipdemirbilek
Copy link
Contributor Author

@nacx thank you. are you planning a new release anytime soon? what version of jclouds should we depend on?

@nacx
Copy link
Member

nacx commented Sep 6, 2023

Actually, we are discussing moving jclouds to the Attic, due to the lack of maintainers and active people in the project. @gaul wanted to do a final release before that happens, but as far as I know there is no deadline for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants