implement support for SharedKey signature #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the recommended signature scheme for Azure, and the only scheme that is supported by the Azurite emulator. https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-shared-key
|
Not sure how this feature should be introduced, but I think it would be nice to have it as an opt-in feature to begin with. There is a lot of parallel code in Happy to take feedback on the direction. |
|
I have validated that I am able to sign in to Azurite using this new signing method, which was not possible with SharedKeyLite. |
nacx
reviewed
Oct 19, 2023
...s/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java
Outdated
Show resolved
Hide resolved
...s/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java
Show resolved
Hide resolved
...s/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java
Outdated
Show resolved
Hide resolved
...s/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java
Show resolved
Hide resolved
Co-authored-by: Ignasi Barrera <nacx@apache.org>
|
@nacx Do you agree with the approach of adding a new authType, or should we have a new property like |
nacx
approved these changes
Oct 20, 2023
|
I think adding the new authType is fine and easy to use/understand for users, so this approach LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the recommended signature scheme for Azure, and the only scheme that is supported by the Azurite emulator.
https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-shared-key