do not remove md in DelimeterFilter then add it by commonPrefixes; just keep it #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is related to gaul/s3proxy#574 |
gaul
requested changes
Nov 14, 2023
| @@ -364,6 +364,9 @@ private SortedSet<StorageMetadata> extractCommonPrefixes(SortedSet<StorageMetada | |||
| o = prefix + o; | |||
| } | |||
| md.setName(o + delimiter); | |||
| if (!contents.contains(md)) { | |||
| contents.add(md); | |||
| } | |||
| contents.add(md); | |||
There was a problem hiding this comment.
This was a typo and I removed it. Thanks!
I add a test |
gaul
requested changes
Nov 14, 2023
| contents.add(md); | ||
| if (!contents.contains(md)) { | ||
| contents.add(md); | ||
| } |
There was a problem hiding this comment.
contents is a Set so this is the same as before. Could you revert it?
There was a problem hiding this comment.
It is reverted now. I thought that item will be replaced if I add an existing item in Set, but actually it will be ignored.
|
Thank you for your contribution @jixinchi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the metadata ends with delimiter, it is removed in
DelimterFilter.apply, then add it back by loopcommonPrefixes. But many information in the metadata lost, such as lastModified time. My solution is keeping them in the DelimeterFilter.