Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#111 Dropping support for older runtimes #115

Merged
merged 152 commits into from
Sep 16, 2024

Conversation

FreeAndNil
Copy link
Contributor

@FreeAndNil FreeAndNil commented Feb 29, 2024

@FreeAndNil
Copy link
Contributor Author

@fluffynuts I've executed steps 1 & 2 of releasing.md

Could you take a look?

Thanks

@fluffynuts
Copy link
Contributor

Will do

@fluffynuts
Copy link
Contributor

I'm wondering if we shouldn't try get out a 2.x release before this - just release off of master. Perhaps even one more after that (there was an issue with mssql introduced by some update to make pgsql better, to do with when parameterisation is done (I forget the rest of the details)).

At the very least, it would solve the "when will this patch be released" questions. Let's keep this branch around though - I want to simplify build, and you've done the right thing (imo) with the major version bump. If there's some really good reason to revive a 2.x release, we could then also use the last release tag as a starting point. What do you think?

@FreeAndNil
Copy link
Contributor Author

FreeAndNil commented Mar 1, 2024 via email

@FreeAndNil FreeAndNil force-pushed the Feature/111-Dropping-support-for-older-runtimes branch 3 times, most recently from 664af41 to 9387b9a Compare March 4, 2024 10:49
@FreeAndNil FreeAndNil changed the base branch from master to Feature/TabsToSpaces March 5, 2024 08:33
@FreeAndNil FreeAndNil force-pushed the Feature/111-Dropping-support-for-older-runtimes branch 2 times, most recently from 8cb606e to 105d6ff Compare March 5, 2024 12:24
@FreeAndNil FreeAndNil force-pushed the Feature/111-Dropping-support-for-older-runtimes branch from ca7204a to a88c5a5 Compare March 5, 2024 12:37
@FreeAndNil FreeAndNil added this to the 3.0.0 milestone Mar 5, 2024
@FreeAndNil FreeAndNil force-pushed the Feature/111-Dropping-support-for-older-runtimes branch from 7d4cf80 to fe4ed63 Compare March 6, 2024 16:20
- SDK-Style
- .net8
- modern C#
FreeAndNil and others added 24 commits September 11, 2024 19:27
…lization-support

dropping legacy serialization support
added source link - see https://github.com/dotnet/sourcelink

before
```
[assembly: CompilationRelaxations(8)]
[assembly: RuntimeCompatibility(WrapNonExceptionThrows = true)]
[assembly: Debuggable(/*Could not decode attribute arguments.*/)]
[assembly: ComVisible(false)]
[assembly: CLSCompliant(true)]
[assembly: AllowPartiallyTrustedCallers]
[assembly: SecurityRules(/*Could not decode attribute arguments.*/)]
[assembly: AssemblyInformationalVersion("3.0.0.0-.NET Standard 2.0")]
[assembly: AssemblyTitle("Apache log4net for .NET Standard 2.0")]
[assembly: AssemblyConfiguration("Retail")]
[assembly: AssemblyProduct("log4net")]
[assembly: AssemblyDefaultAlias("log4net")]
[assembly: AssemblyFileVersion("3.0.0.0")]
[assembly: AssemblyCompany("The Apache Software Foundation")]
[assembly: AssemblyCopyright("Copyright 2004-2024 The Apache Software Foundation.")]
[assembly: AssemblyTrademark("Apache and Apache log4net are trademarks of The Apache Software Foundation")]
[assembly: TargetFramework(".NETStandard,Version=v2.0", FrameworkDisplayName = ".NET Standard 2.0")]
[assembly: AssemblyVersion("3.0.0.0")]
```

after:
```
[assembly: CompilationRelaxations(8)]
[assembly: RuntimeCompatibility(WrapNonExceptionThrows = true)]
[assembly: Debuggable(/*Could not decode attribute arguments.*/)]
[assembly: ComVisible(false)]
[assembly: CLSCompliant(true)]
[assembly: AllowPartiallyTrustedCallers]
[assembly: SecurityRules(/*Could not decode attribute arguments.*/)]
[assembly: TargetFramework(".NETStandard,Version=v2.0", FrameworkDisplayName = ".NET Standard 2.0")]
[assembly: AssemblyCompany("The Apache Software Foundation")]
[assembly: AssemblyConfiguration("Release")]
[assembly: AssemblyCopyright("Copyright © 2004 - 2024 The Apache Software Foundation")]
[assembly: AssemblyDescription("log4net is a tool to help the programmer output log statements to a variety of output targets.\r\nIn case of problems with an application, it is helpful to enable logging so that the problem\r\ncan be located. With log4net it is possible to enable logging at runtime without modifying the\r\napplication binary. The log4net package is designed so that log statements can remain in\r\nshipped code without incurring a high performance cost. It follows that the speed of logging\r\n(or rather not logging) is crucial.\r\n\r\nAt the same time, log output can be so voluminous that it quickly becomes overwhelming.\r\nOne of the distinctive features of log4net is the notion of hierarchical loggers.\r\nUsing these loggers it is possible to selectively control which log statements are output\r\nat arbitrary granularity.\r\n\r\nlog4net is designed with two distinct goals in mind: speed and flexibility\r\n    ")]
[assembly: AssemblyFileVersion("3.0.0.0")]
[assembly: AssemblyInformationalVersion("3.0.0+13eca1117942f3ef5fc742ee70bed6588f274276")]
[assembly: AssemblyProduct("Apache log4net")]
[assembly: AssemblyTitle("Apache log4net for .NET Standard 2.0")]
[assembly: AssemblyMetadata("RepositoryUrl", "https://github.com/apache/logging-log4net")]
[assembly: AssemblyVersion("3.0.0.0")]
```
@ppkarwasz
Copy link
Contributor

Since 3.0.0 was released from this branch, shouldn't you merge this PR?

@fluffynuts fluffynuts self-requested a review September 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropping support for older runtimes
7 participants