Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a bot to check if there is a CHANGES entry for new PRs #13898

Open
stefanvodita opened this issue Oct 12, 2024 · 3 comments · May be fixed by #13909
Open

Create a bot to check if there is a CHANGES entry for new PRs #13898

stefanvodita opened this issue Oct 12, 2024 · 3 comments · May be fixed by #13909
Labels
type:enhancement

Comments

@stefanvodita
Copy link
Contributor

Description

We always have to remind ourselves and others to add a CHANGES entry. We can probably write a GitHub action to check for changes to that file on every new PR and leave a comment warning the author if that's missing.
@prudhvigodithi
Copy link
Contributor

prudhvigodithi commented Oct 12, 2024 •
edited
Loading

Here is the sample PR with change-log verifier action added prudhvigodithi#1, we can add the same workflow to lucene repo. But I see the error dangoslen/changelog-enforcer@v3 is not allowed to be used in apache/lucene.

@prudhvigodithi prudhvigodithi mentioned this issue Oct 12, 2024
Closed
@javanna
Copy link
Contributor

javanna commented Oct 14, 2024

Yes to this! It would be great to combine this with setting the milestone :)

@stefanvodita stefanvodita linked a pull request Oct 14, 2024 that will close this issue
Open
@stefanvodita
Copy link
Contributor Author

@prudhvigodithi - I opened #13898 inspired by your PR, tested it on my fork, and it's working correctly.
@javanna - I like that idea! Maybe we can do that as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add changelog verifier stefanvodita/lucene
3 participants
@javanna @prudhvigodithi @stefanvodita