Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StoredFieldsConsumer finish #13927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix StoredFieldsConsumer finish #13927

wants to merge 1 commit into from
+85 −2

Conversation

linfn
Copy link

@linfn linfn commented Oct 17, 2024 •
edited
Loading

Description

The lastDoc has already invoked startDocument, and the next startDocument docId should be lastDoc + 1.
Additionally, the lastDoc will increment automatically within startDocument

@jpountz
Copy link
Contributor

jpountz commented Oct 18, 2024

Ouch, thanks for finding it and fixing it. Can you add a test?

@linfn linfn force-pushed the patch-1 branch 2 times, most recently from b388216 to af84659 Compare October 19, 2024 01:41
@linfn
Copy link
Author

linfn commented Oct 19, 2024

Ouch, thanks for finding it and fixing it. Can you add a test?

Test added. Let me know if anything else is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linfn @jpountz