Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BooleanScorer to work on top of Scorers rather than BulkScorers. #13931

Merged
merged 5 commits into from
Oct 21, 2024

Commits on Oct 18, 2024

  1. Move BooleanScorer to work on top of Scorers rather than BulkScorers.

    I was looking at some queries where Lucene performs significantly worse than
    Tantivy at https://tantivy-search.github.io/bench/, and found out that we get
    quite some overhead from implementing `BooleanScorer` on top of `BulkScorer`
    (effectively implemented by `DefaultBulkScorer` since it only runs term queries
    as boolean clauses) rather than `Scorer` directly.
    
    The `CountOrHighHigh` and `CountOrHighMed` tasks are a bit noisy on my machine,
    so I did 3 runs on wikibigall, and all of them had speedups for these two
    tasks, often with a very low p-value.
    
    In theory, this change could make things slower when the inner query has a
    specialized bulk scorer, such as `MatchAllDocsQuery` or a conjunction. It does
    feel right to optimize for term queries though.
    jpountz committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    55eeb3f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. forbidden API

    jpountz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    673d768 View commit details
    Browse the repository at this point in the history
  2. CHANGES

    jpountz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    af6c393 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81a1cb4 View commit details
    Browse the repository at this point in the history
  4. tidy

    jpountz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8be6bde View commit details
    Browse the repository at this point in the history