[MSHARED-1152] Remove public modifier for JUnit5 tests

apache · May 5, 2024 · fa7e249 · fa7e249
1 parent d956445
commit fa7e249
Show file tree

Hide file tree

Showing 5 changed files with 110 additions and 110 deletions.
diff --git a/pom.xml b/pom.xml
@@ -81,7 +81,7 @@ under the License.
     </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
-      <artifactId>junit-jupiter</artifactId>
+      <artifactId>junit-jupiter-api</artifactId>
       <scope>test</scope>
     </dependency>
   </dependencies>

diff --git a/src/test/java/org/apache/maven/shared/invoker/DefaultInvokerTest.java b/src/test/java/org/apache/maven/shared/invoker/DefaultInvokerTest.java
@@ -34,19 +34,19 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class DefaultInvokerTest {
+class DefaultInvokerTest {
 
     private Invoker invoker = newInvoker();
     private InvocationRequest request = new DefaultInvocationRequest();
 
     @BeforeEach
-    public void setUp() throws Exception {
+    void setUp() throws Exception {
         request.setDebug(true);
         request.setProperties(getProperties());
     }
 
     @Test
-    public void testBuildShouldSucceed() throws MavenInvocationException, URISyntaxException {
+    void testBuildShouldSucceed() throws MavenInvocationException, URISyntaxException {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setGoals(Arrays.asList("clean", "package"));
@@ -57,7 +57,7 @@ public void testBuildShouldSucceed() throws MavenInvocationException, URISyntaxE
     }
 
     @Test
-    public void testBuildShouldFail() throws MavenInvocationException, URISyntaxException {
+    void testBuildShouldFail() throws MavenInvocationException, URISyntaxException {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setGoals(Arrays.asList("clean", "package"));
@@ -68,7 +68,7 @@ public void testBuildShouldFail() throws MavenInvocationException, URISyntaxExce
     }
 
     @Test
-    public void testBuildShouldTimeout() throws MavenInvocationException, URISyntaxException {
+    void testBuildShouldTimeout() throws MavenInvocationException, URISyntaxException {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setGoals(Arrays.asList("clean", "package"));
@@ -89,7 +89,7 @@ public void testBuildShouldTimeout() throws MavenInvocationException, URISyntaxE
     }
 
     @Test
-    public void testSpacePom() throws Exception {
+    void testSpacePom() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setPomFileName("pom with spaces.xml");
@@ -101,7 +101,7 @@ public void testSpacePom() throws Exception {
     }
 
     @Test
-    public void testSpaceAndSpecialCharPom() throws Exception {
+    void testSpaceAndSpecialCharPom() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setPomFileName("pom with spaces & special char.xml");
@@ -113,7 +113,7 @@ public void testSpaceAndSpecialCharPom() throws Exception {
     }
 
     @Test
-    public void testSpaceSettings() throws Exception {
+    void testSpaceSettings() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setUserSettingsFile(new File(basedir, "settings with spaces.xml"));
@@ -125,7 +125,7 @@ public void testSpaceSettings() throws Exception {
     }
 
     @Test
-    public void testSpaceLocalRepo() throws Exception {
+    void testSpaceLocalRepo() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setLocalRepositoryDirectory(new File(basedir, "repo with spaces"));
@@ -137,7 +137,7 @@ public void testSpaceLocalRepo() throws Exception {
     }
 
     @Test
-    public void testSpaceProperties() throws Exception {
+    void testSpaceProperties() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         Properties props = getProperties();
@@ -152,7 +152,7 @@ public void testSpaceProperties() throws Exception {
     }
 
     @Test
-    public void testPomOutsideProject() throws Exception {
+    void testPomOutsideProject() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         File pom = new File(basedir, "temp/pom.xml");
@@ -165,7 +165,7 @@ public void testPomOutsideProject() throws Exception {
     }
 
     @Test
-    public void testMavenWrapperInProject() throws Exception {
+    void testMavenWrapperInProject() throws Exception {
         File basedir = getBasedirForBuild();
         request.setBaseDirectory(basedir);
         request.setGoals(Collections.singletonList("test-wrapper-goal"));