Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1305] update maven-shared-utils to 3.4.2 #65

Merged
merged 1 commit into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
<version>3.3.4</version>
<version>3.4.2</version>
</dependency>
<dependency>
<groupId>javax.inject</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class DefaultInvokerTest {

Expand Down Expand Up @@ -84,15 +85,13 @@ public void testBuildShouldTimeout() throws MavenInvocationException, URISyntaxE
InvocationResult result = invoker.execute(request);

// We check the exception to be sure the failure is based on timeout.
assertEquals(
"Error while executing external command, process killed.",
result.getExecutionException().getMessage());
assertTrue(result.getExecutionException().getMessage().contains("timed out"));

// WARN - Windows issue MSHARED-867 - Maven and child surefire test process stays alive on Windows
// workaround implemented in this test to timeout test after 15 sec
// please also check timeout logic in maven-shared-utils

// exitCode can't be used cause in case of an timeout it's not correctly
// exitCode can't be used because in case of a timeout it's not correctly
// set in DefaultInvoker. Need to think about this.
// assertEquals( 1, result.getExitCode() );
}
Expand Down