Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-1390] Deprecate InvocationRequest#setGoals #76

Merged
merged 1 commit into from
May 5, 2024
Merged

[MSHARED-1390] Deprecate InvocationRequest#setGoals #76

merged 1 commit into from
May 5, 2024

Conversation

slawekjaranowski
Copy link
Member

michael-o
michael-o requested changes May 4, 2024
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the unrelated changes to a separate PR? It is hard to indentify the actual change.

@slawekjaranowski
Copy link
Member Author

@michael-o - done - only minimal changes

@slawekjaranowski slawekjaranowski merged commit 4e21683 into master May 5, 2024
34 checks passed
@slawekjaranowski slawekjaranowski deleted the MSHARED-1390 branch May 5, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@michael-o michael-o michael-o approved these changes

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slawekjaranowski @olamy @michael-o @CrazyHZM