-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sched/signal: Simplified Implementation for SIGEV_THREAD_TID #13530
Open
Fix-Point
wants to merge
4
commits into
apache:master
Choose a base branch
from
Fix-Point:mybran11
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is to make Coverity happy. Signed-off-by: ouyangxiangzhen <ouyangxiangzhen@xiaomi.com>
This commit simplified the implementation for SIGEV_THREAD_TID. Signed-off-by: ouyangxiangzhen <ouyangxiangzhen@xiaomi.com>
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. Here's why:
To improve this PR:
|
This commit simplified thread ID dispatching logic by integrating it into the `nxsig_dispatch` function. Signed-off-by: ouyangxiangzhen <ouyangxiangzhen@xiaomi.com>
@Fix-Point let's revert the commit 9a9d0a6 too. |
This reverts commit 9a9d0a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit simplified the implementation for SIGEV_THREAD_TID and added the missing siginfo initializer.
Impact
POSIX timer with SIGEV_THREAD_TID flag.
Testing
Tested on QEMU using rt-tests/cyclictest.