Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use of deprecated code in HttpEntity #345

Open
pjfanning opened this issue Oct 29, 2023 · 1 comment
Open

fix use of deprecated code in HttpEntity #345

pjfanning opened this issue Oct 29, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Oct 29, 2023

[warn] /Users/pj.fanning/code/incubator-pekko-http/http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpEntity.scala:666:23: method getFirst in class Attributes is deprecated (since Akka 2.5.7): Attributes should always be most specific, use get[T]
[warn]           _attributes.getFirst[SizeLimit] match {

see akka/akka-http#3463

We might need to undeprecate getFirst.

See #346 - using get instead getFirst breaks lots of tests.

wdyt @jrudolph @mdedetrich @raboof ?

@pjfanning pjfanning added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 29, 2023
@pjfanning pjfanning changed the title fix use of deprecated code fix use of deprecated code in HttpEntity Oct 29, 2023
@jrudolph
Copy link
Contributor

Yep, we tried that before and did not find an easy solution. In the best case, we would dig in and understand what the differences are and understand how to fix the problems in Pekko HTTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants