Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproducible builds: inner functions are not consistently generated on Scala 3 #565

Open
raboof opened this issue Jun 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@raboof
Copy link
Member

raboof commented Jun 7, 2024

reproducing 1.1.0-M1 with set ThisBuild / net.bzzt.reproduciblebuilds.ReproducibleBuildsPlugin.reproducibleBuildsCheckResolver := DefaultMavenRepository; ++3.3; clean; reproducibleBuildsCheck showed two nondeterminisms for me in pekko-http_3-1.1.0-M1.jar :

  • In org/apache/pekko/http/scaladsl/server/directives/FileUploadDirectives.class, one build had default·Directive·storeUploadedFile$$anonfun$1$(final·FileUploadDirectives·$this,·final·String·fieldName$1,·final·Function1·destFn$1,·final·RequestContext·ctx) and default·/*·synthetic·*/·Directive·storeUploadedFile$$anonfun$1(final·String·fieldName$1,·final·Function1·destFn$1,·final·RequestContext·ctx), the other hadn't
  • In org/apache/pekko/http/scaladsl/server/directives/RangeDirectives.class, one build didn't have default·Directive·applyRanges$1$(final·RangeDirectives·$this,·final·LoggingAdapter·log$3,·final·RoutingSettings·settings$6,·final·Seq·ranges), the other did.

Note default·Directive·storeUploadedFile$$anonfun$1$(final·FileUploadDirectives·$this,·final·String·fieldName$1,·final·Function1·destFn$1,·final·RequestContext·ctx) is a function with an actual implementation - if that's not there, does it even work? Or is it duplicated somewhere?

Possibly related to scala/scala3#18248

@raboof raboof added the bug Something isn't working label Jun 7, 2024
@raboof raboof assigned raboof and unassigned raboof Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant