-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pekko-http-jackson: upgrade jackson to 2.16 #368
Conversation
For which release do you plan to merge this? 1.1 or 2? |
@mkurz I think 1.1 is ok for this. Users can also use https://mvnrepository.com/artifact/com.github.pjfanning/pekko-http-jackson if they need support sooner |
It's not about getting it sooner. We want to stay with Jackson 2.14 for a while (until new major Play release next year). After 1.1 got released, how long will you patch 1.0? |
I guess the aim would be to fix major bugs on the 1.0.x for at least a year after a 1.1 release. If and when we do a Pekko HTTP 1.1 release, I am not expecting it to be a release that we will be railroading users onto. |
@mkurz does Play even use the org.apache.pekko:pekko-http-jackson jar? I don't see a dependency on it in https://github.com/playframework/playframework. Jackson 2.15 and 2.16 have some important fixes, including security hardening and I don't want to at least facilitate users to benefit from these fixes. |
5b4cea3
to
fe93a0c
Compare
http-marshallers-java/http-jackson/src/main/resources/reference.conf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
add config support for setting read and write constraints