Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pekko-http-jackson: upgrade jackson to 2.16 #368

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Nov 21, 2023

add config support for setting read and write constraints

@pjfanning pjfanning marked this pull request as draft November 21, 2023 18:08
@mkurz
Copy link
Contributor

mkurz commented Nov 22, 2023

For which release do you plan to merge this? 1.1 or 2?

@pjfanning pjfanning added this to the 1.1.0 milestone Nov 22, 2023
@pjfanning
Copy link
Contributor Author

@mkurz I think 1.1 is ok for this. Users can also use https://mvnrepository.com/artifact/com.github.pjfanning/pekko-http-jackson if they need support sooner

@mkurz
Copy link
Contributor

mkurz commented Nov 22, 2023

It's not about getting it sooner. We want to stay with Jackson 2.14 for a while (until new major Play release next year). After 1.1 got released, how long will you patch 1.0?

@pjfanning
Copy link
Contributor Author

I guess the aim would be to fix major bugs on the 1.0.x for at least a year after a 1.1 release. If and when we do a Pekko HTTP 1.1 release, I am not expecting it to be a release that we will be railroading users onto.

@pjfanning
Copy link
Contributor Author

@mkurz does Play even use the org.apache.pekko:pekko-http-jackson jar? I don't see a dependency on it in https://github.com/playframework/playframework.

Jackson 2.15 and 2.16 have some important fixes, including security hardening and I don't want to at least facilitate users to benefit from these fixes.

@pjfanning pjfanning changed the title [DRAFT] jackson 2.16.0 [DRAFT] pekko-http-jackson: upgrade jackson to 2.16.0 Nov 24, 2023
@pjfanning pjfanning changed the title [DRAFT] pekko-http-jackson: upgrade jackson to 2.16.0 [DRAFT] pekko-http-jackson: upgrade jackson to 2.16 Jan 7, 2024
@pjfanning pjfanning marked this pull request as ready for review January 7, 2024 20:17
@pjfanning pjfanning changed the title [DRAFT] pekko-http-jackson: upgrade jackson to 2.16 pekko-http-jackson: upgrade jackson to 2.16 Jan 7, 2024
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jxnu-liguobin jxnu-liguobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 0d1f29c into apache:main Jan 8, 2024
10 checks passed
@pjfanning pjfanning deleted the jackson-2.16 branch January 8, 2024 09:22
@pjfanning pjfanning mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants