Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Increase stream-cancellation-delay default to 1000 millis" #597

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/src/main/paradox/release-notes/releases-1.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ All the changes in the @ref:[1.0.x releases](releases-1.0.md) up to and includin
### Changes
* Changed names of HTTP status codes 413 and 422 ([PR87](https://github.com/apache/pekko-http/pull/87))
* Parse entire HTTP chunk size ([PR528](https://github.com/apache/pekko-http/pull/528))
* Increased default value of `pekko.http.server.stream-cancellation-delay` and `pekko.http.client.stream-cancellation-delay` from 100 to 1000 millis ([PR590](https://github.com/apache/pekko-http/pull/590))

### Additions
* Add UnsupportedContentTypeException Java DSL ([PR376](https://github.com/apache/pekko-http/pull/376))
Expand Down
4 changes: 2 additions & 2 deletions http-core/src/main/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ pekko.http {
# In most cases, there should be no reason to change this setting.
#
# Set to 0 to disable the delay.
stream-cancellation-delay = 1000 millis
stream-cancellation-delay = 100 millis

http2 {
# The maximum number of request per connection concurrently dispatched to the request handler.
Expand Down Expand Up @@ -532,7 +532,7 @@ pekko.http {
# In most cases, there should be no reason to change this setting.
#
# Set to 0 to disable the delay.
stream-cancellation-delay = 1000 millis
stream-cancellation-delay = 100 millis
}
#client-settings

Expand Down
1 change: 0 additions & 1 deletion http-core/src/test/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ pekko {
default-dispatcher.throughput = 1
}
stream.materializer.debug.fuzzing-mode = off
stream.testkit.all-stages-stopped-timeout = 20 s
}
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ class H2SpecIntegrationSpec extends PekkoFreeSpec(
executable,
"-k", "-t",
"-p", port.toString,
"-o", "9",
"-j", junitOutput.getPath) ++
specSectionNumber.toList.map(number => s"http2/$number")

Expand Down
Loading