Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable mima #91

Merged
merged 2 commits into from
Nov 13, 2023
Merged

re-enable mima #91

merged 2 commits into from
Nov 13, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Nov 10, 2023 •
edited
Loading

  • the mima check was failing in CI until I hardcoded the compare version. This has happened in a few more repos.

nvollmar
nvollmar approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 97d7609 into apache:main Nov 13, 2023
18 checks passed
@pjfanning pjfanning deleted the mima branch November 13, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvollmar nvollmar nvollmar approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@He-Pin He-Pin Awaiting requested review from He-Pin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @nvollmar