Update sbt-java-formatter to 0.8.0

[scala-steward-asf]

About this PR

📦 Updates com.lightbend.sbt:sbt-java-formatter from 0.7.0 to 0.8.0

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lightbend.sbt", artifactId = "sbt-java-formatter" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lightbend.sbt", artifactId = "sbt-java-formatter" }
}]

^{labels: sbt-plugin-update, early-semver-major, semver-spec-minor, commit-count:n:3}

[laglangyue]

lgtm

[raboof]

impressed with how smart Scala Steward is

not sure the import ordering changes are a big improvement, but good to have them managed by the formatter I suppose

[raboof]

Hmm, I guess both 'squash and merge' and 'rebase and merge' would break this, though, right? How should we deal with that? 'squash and merge' and then a follow-up PR to fix the ignore?

[pjfanning]

would rebase and merge work? I presume that one of the merge types works because there would be little point in this otherwise

in the end, there is no harm in doing follow up PRs to fix some of the commit ids in this file

[raboof]

no, only 'create a merge commit' avoids rewriting the commits.

[mdedetrich]

So I a bit late to this whole thing, but the way that historically dealt with .git-blame-ignore-revs is that we only add a commit hash to that file after the PR that does the formatting is merged.

That way the formatting PR can have a nice clean git log (i.e. a single "atomic" commit that only applies the formatting change that is a separate from the other commits), that PR is then merged and then a new PR is made which adds that single formatting commit to .git-blame-ignore-revs

[raboof]

I don't think joining this discussion after only an hour is 'late' at all :)

OK, so your preference is to use 'rebase and merge' and then add the reformatting commit to .git-blame-ignore-revs in a separate PR. I can live with that.

[raboof]

failure was #103 again, re-running