Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test with latests versions of pekko and persistence-jdbc #208

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Sep 17, 2024

I'm hoping this will fix the issue breaking the CI job - https://github.com/apache/pekko-projection/actions/workflows/scala-steward.yml

That job seems to be trying to update files in .github dir and that appears not be allowed by ASF rules applied on GitHub. The updates appear to relate to the new Pekko releases.

@pjfanning pjfanning marked this pull request as draft September 17, 2024 11:04
Update Dependencies.scala

Update Dependencies.scala

pekkoPersistenceJdbc = "1.1.0"

remove staged deps

test with RC versions of connectors-kafka and persistence-jdbc

Update Dependencies.scala

Update Dependencies.scala

pekkoPersistenceJdbc = "1.1.0"
@pjfanning pjfanning changed the title [DO NOT MERGE] test with RC versions of connectors-kafka and persistence-jdbc test with latests versions of pekko and persistence-jdbc Sep 24, 2024
@pjfanning pjfanning marked this pull request as ready for review September 24, 2024 15:17
Copy link

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that scala-steward fails but at least these changes are 👍

@pjfanning pjfanning merged commit 8330d80 into apache:main Sep 24, 2024
28 checks passed
@pjfanning pjfanning deleted the rc-test branch September 24, 2024 16:09
@pjfanning
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants