Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc to 3.25.5 #210

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update protoc to 3.25.5 #210

merged 1 commit into from
Sep 27, 2024

Conversation

pjfanning
Copy link
Contributor

We have updated to protobuf-java 3.25.5 - seems useful to keep protoc in sync.

@raboof
Copy link
Member

raboof commented Sep 27, 2024

should we include something like https://github.com/apache/pekko-grpc/blob/main/project/VersionSyncCheckPlugin.scala here as well?

@raboof raboof merged commit 0fe22df into main Sep 27, 2024
28 checks passed
@pjfanning pjfanning deleted the pjfanning-patch-1 branch September 27, 2024 10:17
@pjfanning
Copy link
Contributor Author

should we include something like https://github.com/apache/pekko-grpc/blob/main/project/VersionSyncCheckPlugin.scala here as well?

pekko-projection-core depends on "org.apache.pekko" %% "pekko-protobuf-v3" % Versions.pekko - a shaded version of pekko-protobuf. So the fact that this is shaded version of protobuf-java 3.25 is not obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants