scala 3 support #77
Merged
scala 3 support #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Sep 1, 2023
•
pjfanning
commented
- Slick does not yet support scala3 (in a full release) so the pekko-projection-slick module is not yet supporting scala 3
- pekko-projection-kafka tests need slick - I can split up the project so that the runtime code is separate from the tests - the runtime project will be able to support Scala 3 as a result but the tests will not run on Scala 3 - I will do this in a follow up PR
Merged
He-Pin
reviewed
Sep 2, 2023
| @@ -153,9 +153,6 @@ lazy val `durable-state` = | |||
| name := "pekko-projection-durable-state") | |||
| .dependsOn(core) | |||
| .dependsOn(testkit % Test) | |||
| .settings( | |||
| // no previous artifact so must disable MiMa until this is released at least once. | |||
| mimaPreviousArtifacts := Set.empty) | |||
There was a problem hiding this comment.
We will need to add this back after 1.0.0
There was a problem hiding this comment.
This disables the mima check - we actually want mima checks on all modules. After 1.0.0 is released, I will set this up properly but this setting will not be added back - so that the mima check will work. I will set a project level setting for mimaPreviousArtifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.