Support empty strings as json nodes^ (#12555)

apache · Mar 5, 2024 · 12060f7 · 12060f7
1 parent fc776e7
commit 12060f7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java b/pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java
@@ -378,6 +378,10 @@ private static List<Map<String, String>> flatten(JsonNode node, JsonIndexConfig
       return Collections.emptyList();
     }
 
+    if (node.isMissingNode()) {
+      return Collections.emptyList();
+    }
+
     // Value
     if (node.isValueNode()) {
       String valueAsText = node.asText();

diff --git a/pinot-spi/src/test/java/org/apache/pinot/spi/utils/JsonUtilsTest.java b/pinot-spi/src/test/java/org/apache/pinot/spi/utils/JsonUtilsTest.java
@@ -632,4 +632,13 @@ public void testInferSchema()
         .addDateTime("hoursSinceEpoch", FieldSpec.DataType.INT, "1:HOURS:EPOCH", "1:HOURS").build();
     Assert.assertEquals(inferredPinotSchema, expectedSchema);
   }
+
+  @Test
+  public void testEmptyString()
+      throws IOException {
+    JsonIndexConfig jsonIndexConfig = new JsonIndexConfig();
+    JsonNode jsonNode = JsonUtils.stringToJsonNode("");
+    List<Map<String, String>> flattenedRecords = JsonUtils.flatten(jsonNode, jsonIndexConfig);
+    assertTrue(flattenedRecords.isEmpty());
+  }
 }