Reduce cpu usage by avoiding throwing an exception during query execu…

…tion (#11715) * Avoid throwing exception * Address review comment Co-authored-by: Xiaotian (Jackie) Jiang <17555551+Jackie-Jiang@users.noreply.github.com> --------- Co-authored-by: Xiaotian (Jackie) Jiang <17555551+Jackie-Jiang@users.noreply.github.com>
apache · Oct 3, 2023 · 1d0303c · 1d0303c
1 parent e0a1f62
commit 1d0303c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/common/Operator.java b/pinot-core/src/main/java/org/apache/pinot/core/common/Operator.java
@@ -72,7 +72,7 @@ default void explainPlan(ExplainPlanRows explainPlanRows, int[] globalId, int pa
    * Returns the index segment associated with the operator.
    */
   default IndexSegment getIndexSegment() {
-    throw new UnsupportedOperationException();
+    return null;
   }
 
   /**

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java b/pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java
@@ -48,15 +48,13 @@ public static void setExecutionStatistics(BaseResultsBlock resultsBlock, List<Op
       if (executionStatistics.getNumDocsScanned() > 0) {
         numSegmentsMatched++;
       }
-      // TODO: Check all operators and properly implement the getIndexSegment and remove this exception handling
-      try {
-        if (operator.getIndexSegment() instanceof MutableSegment) {
-          numConsumingSegmentsProcessed += 1;
-          if (executionStatistics.getNumDocsScanned() > 0) {
-            numConsumingSegmentsMatched++;
-          }
+
+      // TODO: Check all operators and properly implement the getIndexSegment.
+      if (operator.getIndexSegment() instanceof MutableSegment) {
+        numConsumingSegmentsProcessed += 1;
+        if (executionStatistics.getNumDocsScanned() > 0) {
+          numConsumingSegmentsMatched++;
         }
-      } catch (UnsupportedOperationException ignored) {
       }
 
       numDocsScanned += executionStatistics.getNumDocsScanned();