address code comments

apache · Sep 20, 2023 · 51b5cae · 51b5cae
1 parent 32ada40
commit 51b5cae
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java b/pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java
@@ -590,7 +590,6 @@ public HyperLogLogPlus deserialize(byte[] bytes) {
 
     @Override
     public HyperLogLogPlus deserialize(ByteBuffer byteBuffer) {
-      // NOTE: The passed in byte buffer is always BIG ENDIAN
       byte[] bytes = new byte[byteBuffer.remaining()];
       byteBuffer.get(bytes);
       return deserialize(bytes);

diff --git a/...e/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java b/...e/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java
@@ -260,7 +260,7 @@ private static HyperLogLog getDistinctCountHLLResult(Dictionary dictionary,
   private static HyperLogLogPlus getDistinctCountHLLPlusResult(Dictionary dictionary,
       DistinctCountHLLPlusAggregationFunction function) {
     if (dictionary.getValueType() == FieldSpec.DataType.BYTES) {
-      // Treat BYTES value as serialized HyperLogLog
+      // Treat BYTES value as serialized HyperLogLogPlus
       try {
         HyperLogLogPlus hllplus = ObjectSerDeUtils.HYPER_LOG_LOG_PLUS_SER_DE.deserialize(dictionary.getBytesValue(0));
         int length = dictionary.length();

diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/CustomSerDeUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/CustomSerDeUtils.java
@@ -213,11 +213,7 @@ public HyperLogLogPlus deserialize(byte[] bytes) {
     public HyperLogLogPlus deserialize(ByteBuffer byteBuffer) {
       byte[] bytes = new byte[byteBuffer.remaining()];
       byteBuffer.get(bytes);
-      try {
-        return HyperLogLogPlus.Builder.build(bytes);
-      } catch (IOException e) {
-        throw new RuntimeException("Caught exception while de-serializing HyperLogLogPlus", e);
-      }
+      return deserialize(bytes);
     }
   };