Changes as per the PR comment.

apache · Dec 15, 2023 · e4d8e96 · e4d8e96
1 parent 3c9c15a
commit e4d8e96
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/utils/SegmentMetadataUtils.java b/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/utils/SegmentMetadataUtils.java
@@ -50,7 +50,7 @@ public static PropertiesConfiguration getPropertiesConfiguration(SegmentMetadata
 
   public static void savePropertiesConfiguration(PropertiesConfiguration propertiesConfiguration, File indexDir) {
     File metadataFile = SegmentDirectoryPaths.findMetadataFile(indexDir);
-    Preconditions.checkNotNull(metadataFile, "Cannot find segment metadata file under directory: %s", indexDir);
+    Preconditions.checkState(metadataFile != null, "Cannot find segment metadata file under directory: %s", indexDir);
     CommonsConfigurationUtils.saveToFile(propertiesConfiguration, metadataFile);
   }
 

diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java b/pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java
@@ -265,7 +265,7 @@ private static PropertiesConfiguration createPropertiesConfiguration(boolean set
 
     // setting DEFAULT_LIST_DELIMITER
     if (setDefaultDelimiter) {
-      CommonsConfigurationUtils.setListDelimiterHandler(config);
+      setListDelimiterHandler(config);
     }
 
     return config;