address code comments

apache · Sep 20, 2023 · f0cf7f2 · f0cf7f2
1 parent 51b5cae
commit f0cf7f2
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/...apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusAggregationFunction.java b/...apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusAggregationFunction.java
@@ -96,16 +96,14 @@ public void aggregate(int length, AggregationResultHolder aggregationResultHolde
       byte[][] bytesValues = blockValSet.getBytesValuesSV();
       try {
         HyperLogLogPlus hyperLogLogPlus = aggregationResultHolder.getResult();
-        if (hyperLogLogPlus != null) {
-          for (int i = 0; i < length; i++) {
-            hyperLogLogPlus.addAll(ObjectSerDeUtils.HYPER_LOG_LOG_PLUS_SER_DE.deserialize(bytesValues[i]));
-          }
-        } else {
+        if (hyperLogLogPlus == null) {
           hyperLogLogPlus = ObjectSerDeUtils.HYPER_LOG_LOG_PLUS_SER_DE.deserialize(bytesValues[0]);
           aggregationResultHolder.setValue(hyperLogLogPlus);
-          for (int i = 1; i < length; i++) {
-            hyperLogLogPlus.addAll(ObjectSerDeUtils.HYPER_LOG_LOG_PLUS_SER_DE.deserialize(bytesValues[i]));
-          }
+        } else {
+          hyperLogLogPlus.addAll(ObjectSerDeUtils.HYPER_LOG_LOG_PLUS_SER_DE.deserialize(bytesValues[0]));
+        }
+        for (int i = 1; i < length; i++) {
+          hyperLogLogPlus.addAll(ObjectSerDeUtils.HYPER_LOG_LOG_PLUS_SER_DE.deserialize(bytesValues[i]));
         }
       } catch (Exception e) {
         throw new RuntimeException("Caught exception while merging HyperLogLogPlus", e);