Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Pinot hybrid table allowed to be created with different schema #11549

Open
deemoliu opened this issue Sep 8, 2023 · 7 comments
Open

Does Pinot hybrid table allowed to be created with different schema #11549

deemoliu opened this issue Sep 8, 2023 · 7 comments

Comments

@deemoliu
Copy link
Contributor

deemoliu commented Sep 8, 2023

Context

We have created a hybrid table succesfully with different schema in realtime and offline part.

{
"OFFLINE": {
"tableName": "rta_temp_test_OFFLINE",
"tableType": "OFFLINE",
"segmentsConfig": {
"schemaName": "**rta_temp_test1**",
...
"REALTIME": {
"tableName": "rta_temp_test_REALTIME",
"tableType": "REALTIME",
"segmentsConfig": {
"schemaName": "**rta_temp_test**",
...
}

However we also find code, which infers realtime and offline table in one hybrid table should have one schema.

https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java#L451-L464 cc: @ankitsultana

Does Pinot hybrid table allowed to be created with different schema?

@Jackie-Jiang
Copy link
Contributor

No. I think we didn't enforce that before, but no longer allow such configuration going forward

@deemoliu
Copy link
Contributor Author

thanks @Jackie-Jiang for clarification.

@ankitsultana
Copy link
Contributor

If this is not enforced already can we start enforcing it? @deemoliu you were able to create the hybrid table with different schemas with 0.11?

@deemoliu
Copy link
Contributor Author

If this is not enforced already can we start enforcing it? @deemoliu you were able to create the hybrid table with different schemas with 0.11?

there is an attached example in the description of this issue.

@ankitsultana
Copy link
Contributor

The question was whether we hit this issue with 0.11 or a later version. Anyways looks like there's a PR already for this #11591

@Jackie-Jiang
Copy link
Contributor

FYI, #11591 will enforce schema name to be the same as raw table config for each table, which also indices that hybrid table must use the same schema (both offline and real-time side have same raw table name).

Why are you still running on 0.11? Are you planning to directly upgrade to 1.0? That is violating the upgrade policy of not jumping release versions

@ankitsultana
Copy link
Contributor

@Jackie-Jiang : we do upgrades incrementally (1 minor version at a time). Some clusters are using 0.11, some are running 0.12. We have quite a large deployment and it's not easy to keep rolling out new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants