-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate schema name field in table config #11570
Comments
I'd suggest enforcing it instead of trying to handle the bad config by copying and renaming underlying. If we do this transparently, it can actually cause confusion because user might find their uploaded schema disappear, or the modification not reflected. Also, it is adding management overhead. |
Sounds good to me. Schema is also a deprecated field in table configuration, I think it's ok to enforce schema. |
|
One thing I can think of is to have an option to copy schema from referred schema name to table name. |
Thanks @Jackie-Jiang for sharing the PR . My only concern being having it as a periodic job is makes the action hidden from the table owners sight . Should we have it more transparent ? |
Apparently, it's more error-pruning and causing more confusion.
Plan is to always align table name with schema name.
Migration plan:
Controller can scan all tables with customized schema name and copy schema to table name, then update table config. In case the schema name is already occupied. We need to copy schema name to <table_name>_tmp, all table configs. Iterate all tables, then copy schemas from <table_name>_tmp to <table_name>, and update schema name again.
For any new table creation, if there is a reference schema, alway copy the schema then create table without schema name field.
Cc: @Jackie-Jiang
The text was updated successfully, but these errors were encountered: