Add broker query event listener #11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibrewalpratik17
force-pushed
the
add_event_listener
branch
from
4981c45
to
2cac75b
Compare
Codecov Report
@@ Coverage Diff @@
## master #11437 +/- ##
============================================
+ Coverage 63.04% 63.17% +0.12%
+ Complexity 1108 1106 -2
============================================
Files 2320 2325 +5
Lines 124520 124502 -18
Branches 19011 18989 -22
============================================
+ Hits 78507 78651 +144
+ Misses 40422 40257 -165
- Partials 5591 5594 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 132 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tibrewalpratik17
force-pushed
the
add_event_listener
branch
2 times, most recently
from
e51ab49
to
0e803b5
Compare
pinot-spi/src/main/java/org/apache/pinot/spi/queryeventlistener/BrokerQueryEventInfo.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/spi/queryeventlistener/PinotBrokerQueryEventListenerUtils.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/spi/queryeventlistener/PinotBrokerQueryEventListenerUtils.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/pinot/spi/annotations/queryeventlistener/BrokerEventListenerFactory.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/queryeventlistener/BrokerQueryEventListener.java
Outdated
Show resolved
Hide resolved
|
@tibrewalpratik17 : Thanks for raising this. Can you enumerate the remaining tasks we need to do in #10606 so that @Jackie-Jiang is also aware of the remaining changes. |
...org/apache/pinot/plugin/query/event/listener/broker/NoOpBrokerQueryEventListenerFactory.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
add_event_listener
branch
2 times, most recently
from
fed0cf3
to
552921b
Compare
tibrewalpratik17
force-pushed
the
add_event_listener
branch
from
552921b
to
c6ede91
Compare
tibrewalpratik17
force-pushed
the
add_event_listener
branch
3 times, most recently
from
ee9e58d
to
d0cd024
Compare
tibrewalpratik17
force-pushed
the
add_event_listener
branch
from
d0cd024
to
4817a64
Compare
There was a problem hiding this comment.
Lgtm. Left some minor comments. cc: @walterddr @Jackie-Jiang can you folks also take a look?
pinot-spi/src/main/java/org/apache/pinot/spi/queryeventlistener/BrokerQueryEventListener.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/spi/queryeventlistener/PinotBrokerQueryEventListenerUtils.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/queryeventlistener/BrokerQueryEventInfo.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/spi/eventlistener/query/PinotBrokerQueryEventListenerUtils.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
add_event_listener
branch
from
7b43f3b
to
c465389
Compare
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
ankitsultana
approved these changes
Sep 12, 2023
| public interface BrokerQueryEventListener { | ||
|
|
||
| void init(PinotConfiguration eventListenerConfiguration); | ||
| void onQueryCompletion(BrokerQueryEventInfo brokerQueryEventInfo); |
There was a problem hiding this comment.
Do we want to also include onQueryFailure? Counting failed query as completed could cause confusion and unexpected behavior
There was a problem hiding this comment.
Umm we can have a separate onQueryFailure as well but I was planning to leverage errorCode to differentiate between onQuerySuccess and onQueryFailure. But let me know if onQueryCompletion is really confusing.
pinot-spi/src/main/java/org/apache/pinot/spi/eventlistener/query/BrokerQueryEventInfo.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/eventlistener/query/BrokerQueryEventListener.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Sep 20, 2023
...c/main/java/org/apache/pinot/spi/eventlistener/query/PinotBrokerQueryEventListenerUtils.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Sep 20, 2023
walterddr
reviewed
Sep 21, 2023
walterddr
approved these changes
Sep 21, 2023
|
@siddharthteotia @jackjlli Can you also help take a look at this PR? I think this should be very similar to what LinkedIn is doing |
|
Hey @Jackie-Jiang @walterddr can we merge this? |
Jackie-Jiang
added
documentation
Configuration
jackjlli
reviewed
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels:
In #10606 we discussed adding the support for pluggable query event listener. This PR scaffolds the logic for that and is first among series of PRs.
In this PR, we are adding the support for broker query-level event listener. We can register a custom implementation for a broker-level event-listener and pass the class path as a config -
pinot.broker.event.listener.factory.classNameand define our own implementation ofonQueryCompletionmethod of theBrokerQueryEventListenerinterface.Tested this locally by logging the BrokerQueryEventInfo object values in the NoOpBrokerQueryEventListener implementation. It worked as expected.
Re-posting the design doc here -- https://docs.google.com/document/d/11UeU6eNTlyEJ9G096j9XT57QuWgbuCtwnfTC5TQpQ8M/edit#heading=h.uc9rahlz5o0x
cc @ankitsultana