Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning when multi-stage engine planning throws exception #11595

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

We usually log info on query parsing because that indicates user error. For multi-stage planning, exception could indicate some state mismatch, so log warn is more appropriate

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Sep 14, 2023
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some other places in BaseBrokerRequestHandler that also log info after catching exceptions we can revisit later i suppose

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #11595 (edb1542) into master (8abe86b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11595      +/-   ##
============================================
- Coverage     63.05%   63.04%   -0.02%     
  Complexity     1106     1106              
============================================
  Files          2326     2326              
  Lines        124974   124974              
  Branches      19078    19078              
============================================
- Hits          78803    78789      -14     
- Misses        40569    40577       +8     
- Partials       5602     5608       +6     
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 63.01% <100.00%> (-0.01%) ⬇️
java-17 62.90% <100.00%> (-0.02%) ⬇️
java-20 62.91% <100.00%> (+<0.01%) ⬆️
temurin 63.04% <100.00%> (-0.02%) ⬇️
unittests 63.03% <100.00%> (-0.02%) ⬇️
unittests1 67.44% <ø> (-0.02%) ⬇️
unittests2 14.49% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...requesthandler/MultiStageBrokerRequestHandler.java 19.84% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 14f3246 into apache:master Sep 15, 2023
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the better_error_message branch September 15, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants